Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial deviceInfo implementation #249

Closed
3 of 6 tasks
Tracked by #182
gmaclennan opened this issue Sep 6, 2023 · 0 comments · Fixed by #250
Closed
3 of 6 tasks
Tracked by #182

Initial deviceInfo implementation #249

gmaclennan opened this issue Sep 6, 2023 · 0 comments · Fixed by #250

Comments

@gmaclennan
Copy link
Member

gmaclennan commented Sep 6, 2023

Description

This is a subtask of Add device info records #182.

As per #240, we want a user to be able to set a device name at a device level (e.g. for all projects), but the data also needs to be stored in each individual project (so that other clients can read it).

We initially only want a device to only be able to write its own device name/info, and for that information to be shared across all projects. In the future we might want to allow administrators to name devices, and for a device to have different names on different projects.

Tasks for initial implementation

  • Add a deviceInfo internal dataType
  • Add client.setDeviceInfo() and client.getDeviceInfo() methods
  • Create a client SQLite table for persisting local device info.

Tasks for full implementation (tied to project.$member work)

  • Implement project.$member.update() but only allow a device to update it's own deviceInfo (the role that is set by this method has different permissions, so needs to be evaluated separately)
  • From MapeoManager, call project.$member.update() with the current device name when joining a project
  • From the client.setDeviceInfo() method, call project.$member.update() for all current projects on the device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant