Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How to expose setting device name in the API? #240

Closed
gmaclennan opened this issue Aug 31, 2023 · 4 comments
Closed

Question: How to expose setting device name in the API? #240

gmaclennan opened this issue Aug 31, 2023 · 4 comments
Assignees

Comments

@gmaclennan
Copy link
Member

Description

We need a public method for setting a device name. In the future we might want to set additional metadata in addition to the name. Initially a device will only be able to set its own name, but in the future we might want to enable setting of other devices names (e.g. a project coordinator might want to choose the names of other devices).

Suggestions:

  • project.$setDeviceInfo(), project.$getDeviceInfo()
@achou11
Copy link
Member

achou11 commented Aug 31, 2023

is this different than what the $member namespace provides?

https://github.com/digidem/mapeo-core-docs/blob/main/client-docs/README.md#projectmember

@gmaclennan
Copy link
Member Author

Good question, perhaps that API is sufficient? Actually just realizing that we also need to set device name at a device-level (e.g. across projects), and this would be the default for any projects that you join.

@achou11
Copy link
Member

achou11 commented Aug 31, 2023

Good question, perhaps that API is sufficient?

I think it should be for what you're originally describing

Actually just realizing that we also need to set device name at a device-level (e.g. across projects), and this would be the default for any projects that you join.

yeah I think it makes more sense for this issue to suggest a client-level api e.g. client.setDeviceInfo

@achou11
Copy link
Member

achou11 commented Oct 3, 2023

closed via #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants