feat: Add an initial implementation of a minimal TLD-operator #70
Conversation
| }; | ||
| }; | ||
|
|
||
| public shared ({ caller }) func register(domain : Text, records : RegistrationRecords) : async (RegisterResult) { |
There was a problem hiding this comment.
I'm unsure what is the purpose of the name argument. The only thing we do with it right now is check that it matches the name of the domain record. Is there some future context that I'm missing?
There was a problem hiding this comment.
In my understanding the reason for such a spec is to avoid too many structs: RegistrationRecords contain DomainRecord entries, which are also returned by lookup in DomainLookup, hence some redundancy (i.e. when registering a domain one has to check that it matches DomainRecord.name).
Alternatively, one could have a separate struct for registration, say DomainRecordWithoutName, and then join domain with that struct into DomainRecord. I don't have a strong preference.
@keplervital, please correct if my understanding is wrong.
| }; | ||
| }; | ||
|
|
||
| public shared ({ caller }) func register(domain : Text, records : RegistrationRecords) : async (RegisterResult) { |
There was a problem hiding this comment.
In my understanding the reason for such a spec is to avoid too many structs: RegistrationRecords contain DomainRecord entries, which are also returned by lookup in DomainLookup, hence some redundancy (i.e. when registering a domain one has to check that it matches DomainRecord.name).
Alternatively, one could have a separate struct for registration, say DomainRecordWithoutName, and then join domain with that struct into DomainRecord. I don't have a strong preference.
@keplervital, please correct if my understanding is wrong.
Add a Motoko-implementation of a minimal TLD-operator. This initial implementation has a hard-coded TLD (
.icp), which will be changed to a configurable init-parameter at a later point.TT-511