fix: factor out test_utils, clean-up test code #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przydatek
commented
Jan 14, 2025
Comment on lines
+54
to
+57
| # NOTE: The functionality of tld_operator depends on whehter the caller is a controller or not, | ||
| # so we proceed in two steps. Initially the test canister (i.e. tld_operator_test) is not a controller, | ||
| # so we test the behaviour for non-controller callers. Afterwards we make the test canister | ||
| # a controller of tld_operator, and test the behaviour for controller callers. |
There was a problem hiding this comment.
@nathanosdev: following your suggestion from #70 I've removed the "doubled" canister, and run the controller/non-controller tests on a single canister -- this seems simpler indeed.
nathanosdev
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out test functions
test_utils-module, so that they can be used in other tests.Use the new module in existing tests, and simplify the test setup for
tld_operator-tests.