Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Konflux patching renovate schedule #555

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

michael-valdron
Copy link
Member

Description of Changes

Summarize the changes you made as part of this pull request.

Creates a schedule for Konflux patching to happen every Tuesday and Thursday after 9pm, schedule specified in #553, restores default renovate schedule for other devfile registry patching to every 2nd and 4th Thursday after 9pm.

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

I ran the following to validate the renovate config file changes:

  1. export RENOVATE_CONFIG_FILE=$(pwd)/renovate.json
  2. npx --yes --package renovate -- renovate-config-validator

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Ignore warnings to migrate configuration, it appears MintMaker renovate is still using the old configuration specification.

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jan 14, 2025
@michael-valdron
Copy link
Member Author

EC testing is failing as I forgot to rebase, pushing updates now.. 🤦

FYI @Jdubrick

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jan 14, 2025
Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit ebfa78e into devfile:main Jan 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants