-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(konflux): Migrate renovate configuration #553
chore(konflux): Migrate renovate configuration #553
Conversation
Skipping CI for Draft Pull Request. |
Signed-off-by: Michael Valdron <[email protected]>
e6505e6
to
8bdbc5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Will this address the check failures?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -6,8 +6,8 @@ | |||
":gitSignOff" | |||
], | |||
"timezone": "America/Toronto", | |||
"schedule": ["on the 2nd and 4th day instance on thursday after 9pm"], | |||
"enabledManagers": ["regex", "github-actions"], | |||
"schedule": ["after 9pm on tuesday and thursday"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ: Was this a requirement from the konflux side? I'm only thinking it might increase the noise for image updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if something like https://docs.renovatebot.com/key-concepts/scheduling/#schedule-when-to-update-specific-dependencies could be of help (so we can have the tekton
updates on a different - more often - schedule).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ: Was this a requirement from the konflux side? I'm only thinking it might increase the noise for image updates.
Not a requirement from the Konflux side but due to the frequency in Konflux updates and the outdated images causing EC testing to fail, blocks deployment promotions, we need a higher frequency in renovate patching on the tekton task images.
I was wondering if something like https://docs.renovatebot.com/key-concepts/scheduling/#schedule-when-to-update-specific-dependencies could be of help (so we can have the
tekton
updates on a different - more often - schedule).
I like this suggestion, I've opened #555 to use the Tuesday/Thursday schedule for only Konflux patching while everything else will be restored to every 2nd and 4th Thursday evening.
Description of Changes
Summarize the changes you made as part of this pull request.
This PR migrates the old renovate config to one that works with Konflux. In order to meet the needs of MintMaker Renovate via Konflux as well as the Konflux patch updates, the following changes have been made:
tekton
underenabledManagers
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
fixes devfile/api#1667
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
I ran the following to validate the renovate config file changes:
export RENOVATE_CONFIG_FILE=$(pwd)/renovate.json
npx --yes --package renovate -- renovate-config-validator
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.
Ignore warnings to migrate configuration, it appears MintMaker renovate is still using the old configuration specification.