Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(konflux): Migrate renovate configuration #553

Merged

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jan 13, 2025

Description of Changes

Summarize the changes you made as part of this pull request.

This PR migrates the old renovate config to one that works with Konflux. In order to meet the needs of MintMaker Renovate via Konflux as well as the Konflux patch updates, the following changes have been made:

  • Include tekton under enabledManagers
  • Increase run schedule for renovate to avoid Enterprise Contract failures due to out of date Konflux image references

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

fixes devfile/api#1667

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

I ran the following to validate the renovate config file changes:

  1. export RENOVATE_CONFIG_FILE=$(pwd)/renovate.json
  2. npx --yes --package renovate -- renovate-config-validator

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Ignore warnings to migrate configuration, it appears MintMaker renovate is still using the old configuration specification.

Copy link

openshift-ci bot commented Jan 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron michael-valdron force-pushed the chore/konflux-renovate-config branch from e6505e6 to 8bdbc5d Compare January 13, 2025 16:39
@michael-valdron michael-valdron marked this pull request as ready for review January 13, 2025 21:37
@michael-valdron michael-valdron requested a review from a team as a code owner January 13, 2025 21:37
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Will this address the check failures?

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jan 13, 2025
Copy link

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 3d013d3 into devfile:main Jan 13, 2025
12 of 14 checks passed
@@ -6,8 +6,8 @@
":gitSignOff"
],
"timezone": "America/Toronto",
"schedule": ["on the 2nd and 4th day instance on thursday after 9pm"],
"enabledManagers": ["regex", "github-actions"],
"schedule": ["after 9pm on tuesday and thursday"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: Was this a requirement from the konflux side? I'm only thinking it might increase the noise for image updates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if something like https://docs.renovatebot.com/key-concepts/scheduling/#schedule-when-to-update-specific-dependencies could be of help (so we can have the tekton updates on a different - more often - schedule).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thepetk

QQ: Was this a requirement from the konflux side? I'm only thinking it might increase the noise for image updates.

Not a requirement from the Konflux side but due to the frequency in Konflux updates and the outdated images causing EC testing to fail, blocks deployment promotions, we need a higher frequency in renovate patching on the tekton task images.

I was wondering if something like https://docs.renovatebot.com/key-concepts/scheduling/#schedule-when-to-update-specific-dependencies could be of help (so we can have the tekton updates on a different - more often - schedule).

I like this suggestion, I've opened #555 to use the Tuesday/Thursday schedule for only Konflux patching while everything else will be restored to every 2nd and 4th Thursday evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devfile registry konflux component task image references are not seeing updates
3 participants