fix: Safari noSuchWindowException and Page/Frame not ready

[scottmries]

QA Notes:

The following code occasionally caused Safari to throw a noSuchWindowException around 1 in 10 times, and I expect it never to do so now.

require "selenium-webdriver"
require_relative "../../lib/axe/api/run"
require "json"


driver = Selenium::WebDriver.for :safari
# driver.navigate.to "http://google.com"
driver.navigate.to "https://dequeuniversity.com/demo/mars/"

res = Axe::Core.new(driver).call Axe::API::Run.new.with_options

puts JSON.pretty_generate res.results.to_h

driver.quit

Note the commented # driver.navigate to "http://google.com". Issue #353 notes that attempting to navigate to http://google.com would also occasionally cause an exception "Page/Frame not ready" to be thrown; it should no longer do so.

Please uncomment this line, comment driver.navigate.to "https://dequeuniversity.com/demo/mars/" and test again. This fix is included here since they are closely related.

Closes: #352
Closes: #353

[scottmries]

This now checks readyState repeatedly for a 'complete' state. Previously, the state would be checked once; given an 'interactive' state, assert_frame_ready would fail and never succeed, hence #353.

[Zidious]

The noSuchWindowException change is looking good! I had a question on the Page/Frame not ready change inline -

[Zidious]

I know this has been here for a while, but have you tested if we even need this anymore? I know for Selenium they have implemented the WebDriver as per the spec which by default is set to so we should be waiting for the page finish loading before trying to inject:

An HTTP session has an associated page loading strategy, which is one of the keywords from the table of page load strategies. This is initially set to normal.

[dbjorge]

If it's for backcompat with older selenium versions that we expect are missing that behavior, it'd be helpful to leave a comment explaining that

[scottmries]

I tested removing this against both latest 3 and 4, and I didn't find any issue against either the "fast" or "slow" URLs in my repro script. I'm removing it for this reason. If I'm misunderstanding, please let me know.
It seems odd that it would work on latest 3, but there may have been a fix in place since this was first written.

[Zidious]

👇