chore: RC v4.9.1 #388
Merged
chore: RC v4.9.1 #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Closes: #343 No QA Required
QA Notes: The following code occasionally caused Safari to throw a `noSuchWindowException` around 1 in 10 times, and I expect it never to do so now. ``` require "selenium-webdriver" require_relative "../../lib/axe/api/run" require "json" driver = Selenium::WebDriver.for :safari # driver.navigate.to "http://google.com" driver.navigate.to "https://dequeuniversity.com/demo/mars/" res = Axe::Core.new(driver).call Axe::API::Run.new.with_options puts JSON.pretty_generate res.results.to_h driver.quit ``` Note the commented `# driver.navigate to "http://google.com"`. Issue #353 notes that attempting to navigate to `http://google.com` would also occasionally cause an exception "Page/Frame not ready" to be thrown; it should no longer do so. Please uncomment this line, comment `driver.navigate.to "https://dequeuniversity.com/demo/mars/"` and test again. This fix is included here since they are closely related. Closes: #352 Closes: #353
This pull request updates the version of [`axe-core`](https://npmjs.org/axe-core) to v4.9.1. This PR was opened by a robot 🤖 🎉. Co-authored-by: AdnoC <[email protected]>
github-actions
bot
added
the
release
michael-siek
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.9.1 (2024-05-08)
Bug Fixes