Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: epoch #5
feat: epoch #5
Changes from all commits
3e795ce
f7b882a
ddde6e6
6bf9f06
5f8fc37
dd52cec
d6982d9
6ab31cb
bd14bb0
0c70793
242ab9f
b920024
dfbc841
e9d28d9
8326899
640568e
ea3f6cb
e7efafb
2ba458d
47a9a5e
7f207f3
9db3c6c
2add7e2
cee3e1a
cc6190a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 65 in src/contracts/Arbitrable.sol
GitHub Actions / Lint Commit Messages
Check warning on line 65 in src/contracts/Arbitrable.sol
GitHub Actions / Lint Commit Messages
Check warning on line 35 in src/contracts/EBORequestCreator.sol
GitHub Actions / Lint Commit Messages
Check warning on line 35 in src/contracts/EBORequestCreator.sol
GitHub Actions / Lint Commit Messages
Check warning on line 36 in src/contracts/EBORequestCreator.sol
GitHub Actions / Lint Commit Messages
Check warning on line 36 in src/contracts/EBORequestCreator.sol
GitHub Actions / Lint Commit Messages
Check warning on line 81 in src/interfaces/IArbitrable.sol
GitHub Actions / Lint Commit Messages
Check warning on line 81 in src/interfaces/IArbitrable.sol
GitHub Actions / Lint Commit Messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't out there a package with The Graph's interfaces? 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe yes but we need just 1 function, thats why I create the interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the linter complain when no initial underscore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK to be honest, I assume that for constants should start with underscore
Check warning on line 18 in test/integration/arbitrum/IntegrationBase.sol
GitHub Actions / Lint Commit Messages
Check warning on line 18 in test/integration/arbitrum/IntegrationBase.sol
GitHub Actions / Lint Commit Messages