feat: epoch #5
Merged
feat: epoch #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRT-66 EBORequestCreator validate epoch number against the epoch manager
Validate that the epoch number is not in the future. In the constructor, get the current epoch number and only allow the creation of requests for epochs equal or more that that one https://arbiscan.io/address/0x5A843145c43d328B9bB7a4401d94918f131bB281 |
0xShaito
reviewed
Aug 9, 2024
0xShaito
reviewed
Aug 9, 2024
0xShaito
reviewed
Aug 9, 2024
0xShaito
requested changes
Aug 9, 2024
0xJabberwock
requested changes
Aug 13, 2024
Comment on lines
+1
to
+4
| // SPDX-License-Identifier: UNLICENSED | ||
| pragma solidity 0.8.26; | ||
|
|
||
| interface IEpochManager { |
There was a problem hiding this comment.
Isn't out there a package with The Graph's interfaces? 😕
There was a problem hiding this comment.
maybe yes but we need just 1 function, thats why I create the interface
Comment on lines
+1
to
+4
| // SPDX-License-Identifier: MIT | ||
| pragma solidity 0.8.26; | ||
|
|
||
| address constant _EPOCH_MANAGER = 0x5A843145c43d328B9bB7a4401d94918f131bB281; |
There was a problem hiding this comment.
Does the linter complain when no initial underscore?
There was a problem hiding this comment.
IDK to be honest, I assume that for constants should start with underscore
0xShaito
previously approved these changes
Aug 14, 2024
0xShaito
previously approved these changes
Aug 15, 2024
0xShaito
approved these changes
Aug 15, 2024
0xJabberwock
approved these changes
Aug 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-66