Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8517: Bump Kinesis version to 2.17.241 to fix Jackson incompatibility when using the sink Kinesis #141

Merged
merged 1 commit into from
Dec 18, 2024
Merged

DBZ-8517: Bump Kinesis version to 2.17.241 to fix Jackson incompatibility when using the sink Kinesis #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion debezium-server-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<packaging>jar</packaging>

<properties>
<version.kinesis>2.13.13</version.kinesis>
<version.kinesis>2.17.241</version.kinesis>
<version.sqs>2.13.13</version.sqs>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the version 2.17.241 is a very old version as well, but it's the one used in Debezium core.
Moreover, the version.sqs should use the same version as the version.kinesis to avoid incompatibilities.
But we would like to get some feedback from you about how to verify these changes and cover both kinesis and sqs (ideally, using a local machine).

Copy link
Contributor

@jpechane jpechane Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the sink was developed we tested it against rela Kinesis. Today it might be possible to use localstack to give it a try. I can't confirm it will work but it would be good to check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using localstack works fine, I can rebase this PR with #140, so we can add an additional sink job to validate this change and also cover the Kinesis sink, wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sgitario Sounds good! Could you please create a Jira and attribute commits in this PR to it using DBZ-xxx prefix in commit message. We'll merge the PR then and you can add the localstackt to the server validation PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: https://issues.redhat.com/browse/DBZ-8517

<version.pubsub>26.17.0</version.pubsub>
<version.pulsar>2.10.1</version.pulsar>
Expand Down
Loading