-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBZ-8517: Bump Kinesis version to 2.17.241 to fix Jackson incompatibility when using the sink Kinesis #141
DBZ-8517: Bump Kinesis version to 2.17.241 to fix Jackson incompatibility when using the sink Kinesis #141
Conversation
@@ -12,7 +12,7 @@ | |||
<packaging>jar</packaging> | |||
|
|||
<properties> | |||
<version.kinesis>2.13.13</version.kinesis> | |||
<version.kinesis>2.17.241</version.kinesis> | |||
<version.sqs>2.13.13</version.sqs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the version 2.17.241 is a very old version as well, but it's the one used in Debezium core.
Moreover, the version.sqs should use the same version as the version.kinesis to avoid incompatibilities.
But we would like to get some feedback from you about how to verify these changes and cover both kinesis and sqs (ideally, using a local machine).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the sink was developed we tested it against rela Kinesis. Today it might be possible to use localstack to give it a try. I can't confirm it will work but it would be good to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using localstack works fine, I can rebase this PR with #140, so we can add an additional sink job to validate this change and also cover the Kinesis sink, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sgitario Sounds good! Could you please create a Jira and attribute commits in this PR to it using DBZ-xxx prefix in commit message. We'll merge the PR then and you can add the localstackt to the server validation PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
96284dc
to
b200b85
Compare
@Sgitario Applied, thanks! |
Bumping the Kinesis version to 2.17.241 will resolve the jackson incompatibility issue when running the Debezium server:
How to reproduce
To reproduce this issue, follow the next steps:
1.- Build the Debezium server distribution:
./mvnw clean package -DskipITs -DskipTests -Passembly
2.- Start Up postgres listening at localhost:5432, use the following docker-compose.yml as a reference: https://github.com/debezium/debezium-server/pull/140/files#diff-56a998a8165ad21afa94ccb494c4b08f843d129dfd9e897780e5d766f59c1aaeR103
3.- Copy the application properties of the distro folder to the Debezium target folder:
The relevant part of this application properties file is:
4.- Then, when running the Debezium server:
In main, the
run.sh
fails with the above exception.Fixes https://issues.redhat.com/browse/DBZ-8517