Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move analysis module action #571

Merged
merged 17 commits into from
May 30, 2024
Merged

move analysis module action #571

merged 17 commits into from
May 30, 2024

Conversation

jharenza
Copy link
Collaborator

@jharenza jharenza commented May 6, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR moves the analysis module back into GHA now that the new docker image is built

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza requested a review from a team as a code owner May 6, 2024 16:36
This was referenced May 15, 2024
@jharenza jharenza requested review from devbyaccident and rjcorb May 30, 2024 19:17
@jharenza
Copy link
Collaborator Author

@devbyaccident and @rjcorb - this should pass fully now. @rjcorb can you review the MB, GSVA, etc module updates and @devbyaccident can you review the action updates? :)

Copy link
Member

@devbyaccident devbyaccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actions LGTM!

Copy link

@rjcorb rjcorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I was able to replicate all results in updated modules.

@jharenza jharenza merged commit d98b38c into dev May 30, 2024
28 checks passed
@jharenza jharenza deleted the analysis-module-action branch May 30, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants