Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UMAP script #570

Closed
wants to merge 17 commits into from
Closed

Conversation

rjcorb
Copy link

@rjcorb rjcorb commented May 3, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

Closes #569. This PR adds a script to molecular-subtyping-MB/ to generate a UMAP of MB SHH samples based on most variable methylation array probes.

What was your approach?

adapted from this code: https://jharenza.github.io/mb-subtypes/explore-medulloblastoma-unsupervised-clustering.nb.html

What GitHub issue does your pull request address?

#569

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Check code and ensure script runs successfully:

R -e "rmarkdown::render('06-mb-shh-umap.Rmd')"

Is there anything that you want to discuss further?

I have the UMAP points sized by age range currently, to add some additional info on outliers and un-subtyped MB SHH samples. We may not want to keep this in the final figure.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

UMAP

What is your summary of the results?

Overall we see good clustering of MB SHH samples into the four subtypes. There are a few samples not cluttering with their subtype, including a few adolescent/adult samples with the infantile MB SHH samples. We may need to review these samples to check how they were classified into subtypes.

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@rjcorb rjcorb requested a review from a team as a code owner May 3, 2024 20:56
@rjcorb rjcorb added the draft label May 3, 2024
@jharenza
Copy link
Collaborator

hi @rjcorb can you stack the MB PRs on #571? I had to remove MM2S code there.

width = 5.5, height = 3.5)
```

Identify 10k most variable probes among MB Group 3/4 samples
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This night be a typo, do you mean 20k?

@jharenza jharenza self-requested a review July 3, 2024 01:25
@jharenza
Copy link
Collaborator

jharenza commented Jul 3, 2024

@rjcorb can you do me a favor and label the following samples on the UMAP? These have very high-conf non-MB histologies and I wonder if these are some of the problematic samples.
7316-1884
7316-1676
7316-1666
7316-3202

Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also create an mb umap by the 4 subtypes with the expression data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants