Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 fixed collapse bug
Purpose/implementation Section
What scientific question is your analysis addressing?
A bug fix in collapse gene logic, and issues with package availability in docker pull
What was your approach?
Look at the code, identify the cause
What GitHub issue does your pull request address?
The return for the function was happening inside loop, instead of returning after the loop completed, resulting on in only one duplicate gene being collapsed and all others being dropped. Also changes one of the step to pull from annoFuse docker instead of tidyverse to make required
optparse
package readily availableDirections for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Updates to python script and results from https://cavatica.sbgenomics.com/u/d3b-bixu-ops/open-target-tcga-rnaseq-counts/tasks/6f6651b8-850d-4cfc-96fe-467f1b4b455a/
Is there anything that you want to discuss further?
Address #550 #552 #551
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
Outputs from https://cavatica.sbgenomics.com/u/d3b-bixu-ops/open-target-tcga-rnaseq-counts/tasks/6f6651b8-850d-4cfc-96fe-467f1b4b455a/
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.