Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3b Bix Dev Feature: Fix bug #552

Closed
migbro opened this issue Feb 29, 2024 · 1 comment
Closed

D3b Bix Dev Feature: Fix bug #552

migbro opened this issue Feb 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@migbro
Copy link

migbro commented Feb 29, 2024

[Required] Is this a new tool/workflow?

No

[Required] Which tools/workflows would you like to update/add?

Provide software links and dockerPull location if applicable

analyses/collapse-rnaseq/cwl/scripts/liftover_collapse_rnaseq.py

[Required] What features (new params, inputs, outputs, etc) would you like to add to each?

Add reference files and test input locations if applicable

return happens too soon, causing all duplicate genes to be collapsed to be dropped, except one, in

def collapse_dups(dup_gene_sym_dict):
"""
Get highest mean for repeated gene symbols and output that row
"""
for gene_sym in dup_gene_sym_dict:
means = [mean(data) for data in dup_gene_sym_dict[gene_sym]]
top_idx = means.index(max(means))
out_data = "{}\t{}\n".format(gene_sym, '\t'.join(list(map(str, dup_gene_sym_dict[gene_sym][top_idx]))))
return out_data

[Optional] How long do you think this work will take?

an hour

[Optional] Who will complete this work?

@migbro

Ticket will be considered resolved either by a successful PR with updated release if applicable, or a simple denial of the request backed by a good reason

@migbro migbro added the bug Something isn't working label Feb 29, 2024
@migbro migbro self-assigned this Feb 29, 2024
@migbro migbro mentioned this issue Feb 29, 2024
5 tasks
@jharenza
Copy link
Collaborator

jharenza commented Mar 1, 2024

completed with #553

@jharenza jharenza closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants