add dockerfile in docs #3917
Merged
add dockerfile in docs #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimtb
reviewed
Nov 26, 2024
There was a problem hiding this comment.
I think the addition of the dockerfile should replace the osrf/ros:humble-desktop of the first pre-requisite. I would also add a docker command to build the image and run with interactive console (Something like docker build -t conanio/ros-humble . && docker run -it conanio/ros-humble).
Let's also remove the lines
RUN git clone https://github.com/conan-io/examples2.git /workspace/examples2
WORKDIR /workspace/examples2/examples/tools/ros/rosenv
So the starting point in the second pre-requisite remains the same whether the reader is using its own system with ROS installed or the docker image
danimtb
reviewed
Nov 26, 2024
Co-authored-by: Daniel <[email protected]>
danimtb
reviewed
Nov 27, 2024
| RUN apt-get update && apt-get install -y \ | ||
| curl \ | ||
| python3-pip \ | ||
| git \ |
There was a problem hiding this comment.
Add nav2_msgs to support blogpost example at conan-io/examples2#168
Suggested change
| git \ | |
| git \ | |
| ros-humble-nav2-msgs \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.