Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to COLMAP HEAD #132

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Update to COLMAP HEAD #132

merged 6 commits into from
Nov 15, 2024

Conversation

sarlinpe
Copy link
Member

@sarlinpe sarlinpe commented Nov 5, 2024

Update to colmap/colmap@3254263. I don't know how you want to handle older versions of COLMAP - maybe by creating a new release? Merging this into the COLMAP repos would definitely make this easier.

@B1ueber2y
Copy link

@ahojnnes
Copy link
Contributor

ahojnnes commented Nov 5, 2024

Eventually, we should introduce a global_mapper option into colmap. This indeed becomes difficult to maintain in the long-term. Meanwhile, I don't think there is an ambition to support multiple versions of colmap. The only use case for not using the FetchContent approach is when one wants to make code changes to both glomap and colmap at the same time.

@ahojnnes ahojnnes requested review from lpanaf and ahojnnes November 5, 2024 13:09
@B1ueber2y
Copy link

The intention of this update was to support in glomap the newly introduced camera model (colmap/colmap#2786) and updated undistortion (colmap/colmap#2857) for Fisheye images. This workflow may need to be gone through repeatedly in the future when the base classes are updated.

@sarlinpe sarlinpe marked this pull request as ready for review November 5, 2024 21:50
@ahojnnes ahojnnes merged commit 664aa7c into main Nov 15, 2024
7 checks passed
@ahojnnes
Copy link
Contributor

Thanks very much @sarlinpe !

@lpanaf
Copy link
Collaborator

lpanaf commented Nov 15, 2024

Sorry but I just have time to look into it. Thank you so much @sarlinpe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants