-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building issue, colmap version requirement? #21
Comments
Need: |
Could you show the full error message and build log? It will be good to understand the callsite where this error is triggered. Thank you. |
the latest commit of glomap needs latest version of colmap |
My first error is resolved specifically with: After I updated my packages with what I got above, I'm left with this error:
Any suggestion as to how to resolve this? |
It looks like you have an active python environment and that may be the reason you link inconsistent libraries into the final binary. |
Despite that Python issue, I'd like to stress the importance of adding a version requirement for glog (the original issue of this thread). On Arch, glog v0.7.x is the current maintained version, with which the glomap build fails. |
@JonasKonrad I believe, after we merge this PR: #132, glog 0.7.X should work as well. |
@ahojnnes It does, but not out of the box. Had to change a detail in FindDependencies.cmake. Exporting the version definitions there is restricted to MSVC. This is not how Colmap incorporates Glog. I can provide a PR. Btw., I had to go through some bugs before verifying this, because I made use of my installed Colmap, which was up-to-date with the Colmap repo at that time. Basically, Colmap commit #2896 regarding the BundleAdjustment interface are breaking for Glomap. So, I'd love to see find_package(COLMAP $version REQUIRED) statement in glomap's FindDependencies.cmake, but I perfectly get that you cannot do this at at this project stage (if ever). |
I'm trying to build glomap but faced this error:
Is there a requirement for colmap version?
The text was updated successfully, but these errors were encountered: