fixing some styling bugs #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@codewithvoid I mean here a default profile picture just in the case the image is not provided from the src |
|
@codewithvoid did you review the code? |
|
Thanks @bruxx-6243 for making the changes. I think suggestions related to images are valid. (alt text and default profile picture) @PriteshKiri is already fixing the width issue in his PRs. Also, can you sync your changes once..I am seeing additional files in data/users directory. |
|
Done ✅ @codewithvoid |
|
I am seeing some additional files in this change due to format fix. I have sent it separately in #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @codewithvoid check out some changes I've made.
On small screen the width full was creating this small issue.
And when we're fetching data for those user image that can't be load I think it's better to specify exactly the alt with the name of the user
For example for some image from this twitter url is giving 404 status for those who live in region like Russia. @codewithvoid How do you think if we set a default profile picture when the image src is not correctly fetched???