Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fyst 1516 add email validation step to prior year access flow #5300
Fyst 1516 add email validation step to prior year access flow #5300
Changes from all commits
30dd34b
2d1f3f1
36a8be4
eb43c45
ca18535
a8ad9db
1cfc369
5b22894
a32e759
a0969e3
f1e5246
234b1e3
1b95140
0798ab6
4181a66
5162bf6
c39a237
be8795e
e7d479c
90da001
10b64ec
e3be6ee
4bc1aaf
8b830ce
32803b9
9b26ce6
cff9432
a9df1c4
8d0787e
01a2ea6
9fa60cb
33a7375
7b4a3eb
192cecc
a6edbfd
a75955b
b5ec8d3
48a8f45
d3e415f
ad8f820
72af870
2daf9d2
d49f10c
5206023
d357bbc
dc36bc6
77f5d38
aea0433
e0e9bd1
b44de74
a9218ae
d92c736
2a67c98
8ff20b5
85fe8b2
6b2ed42
cd48cc0
016c423
1ff7332
9364004
d3c660d
49c8800
347645d
495406f
884e042
7c0bd3c
94035b6
3f68533
94ec192
0c89122
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i should have asked this during the mob review but why
attr_accessor
instead ofset_attributes_for
? is it because we're not actually updating any db records?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this normal? seems weird to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seemed weird to me too but it seems like we use this pattern 🙈 maybe there should be
PRIORITY_IMMEDIATE
or something...PRIORITY_HIGHEST
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pebble] also i wanted to point out here, if you're renaming this file in your PR, you'd want to delete the old one too. i don't see that happening in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this!
This file was deleted.