Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fyst 1516 add email validation step to prior year access flow #5300

Open
wants to merge 24 commits into
base: FYST-1466-prior-year-access-mvp
Choose a base branch
from

Conversation

DrewProebstel
Copy link
Contributor

@DrewProebstel DrewProebstel commented Dec 30, 2024

Link to pivotal/JIRA issue

-https://codeforamerica.atlassian.net/browse/FYST-1516

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Unit/integration/manual tests
    • Test data used
  • Specify any relevant testing environments used (e.g., development, staging, demo, Heroku).
  • Risk Assessment
    • Risks or side effects associated with the changes and how they were mitigated.
    • Highlight areas that may need extra attention during code review or testing.
    • Paste SQL queries or output where relevant

Screenshots (for visual changes)

  • Before
  • After

Copy link

Heroku app: https://gyr-review-app-5300-d758a122588b.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5300 (optionally add --tail)

@anisharamnani anisharamnani changed the base branch from main to FYST-1466-prior-year-access-mvp January 6, 2025 20:30
Drew Proebstel added 3 commits January 6, 2025 13:05
… into FYST-1516-add-email-validation-step-to-prior-year-access-flow
db/schema.rb Outdated
@@ -647,6 +647,33 @@
t.index ["name"], name: "index_coalitions_on_name", unique: true
end

create_table "completed_2023_tax_return_logs", force: :cascade do |t|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ these schema change shouldn't be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants