Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: url encode branch name in test results comment link to dash #692

Merged
merged 3 commits into from
Sep 9, 2024
Merged

fix: url encode branch name in test results comment link to dash #692

merged 3 commits into from
Sep 9, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team September 5, 2024 21:19
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         433      433           
  Lines       36752    36752           
=======================================
  Hits        36051    36051           
  Misses        701      701
Flag Coverage Δ
integration 98.09% <100.00%> (ø)
latest-uploader-overall 98.09% <100.00%> (ø)
unit 98.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.00% <100.00%> (ø)
OutsideTasks 98.09% <100.00%> (ø)
Files Coverage Δ
services/tests/test_test_results.py 100.00% <100.00%> (ø)
services/urls.py 95.95% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (37f512c) to head (51d52ef).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         433      433           
  Lines       36752    36752           
=======================================
  Hits        36051    36051           
  Misses        701      701
Flag Coverage Δ
integration 98.09% <100.00%> (ø)
latest-uploader-overall 98.09% <100.00%> (ø)
unit 98.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.00% <100.00%> (ø)
OutsideTasks 98.09% <100.00%> (ø)
Files with missing lines Coverage Δ
services/tests/test_test_results.py 100.00% <100.00%> (ø)
services/urls.py 95.95% <100.00%> (ø)

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (37f512c) to head (51d52ef).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         433      433           
  Lines       36752    36752           
=======================================
  Hits        36051    36051           
  Misses        701      701
Flag Coverage Δ
integration 98.09% <100.00%> (ø)
latest-uploader-overall 98.09% <100.00%> (ø)
unit 98.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.00% <100.00%> (ø)
OutsideTasks 98.09% <100.00%> (ø)
Files Coverage Δ
services/tests/test_test_results.py 100.00% <100.00%> (ø)
services/urls.py 95.95% <100.00%> (ø)

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (37f512c) to head (51d52ef).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         475      475           
  Lines       38107    38107           
=======================================
  Hits        37396    37396           
  Misses        711      711
Flag Coverage Δ
integration 98.09% <100.00%> (ø)
latest-uploader-overall 98.09% <100.00%> (ø)
unit 98.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.10% <100.00%> (ø)
OutsideTasks 98.09% <100.00%> (ø)
Files with missing lines Coverage Δ
services/tests/test_test_results.py 100.00% <100.00%> (ø)
services/urls.py 95.95% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

matt-codecov
matt-codecov approved these changes Sep 5, 2024
View reviewed changes
services/tests/test_test_results.py Outdated
tn = TestResultsNotifier(commit, None, None, None, payload)
print(commit.branch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 9, 2024
@joseph-sentry joseph-sentry removed this pull request from the merge queue due to a manual request Sep 9, 2024
@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit a4ee062 Sep 9, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/urlencode-comment branch September 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-codecov matt-codecov matt-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @matt-codecov