fix: url encode branch name in test results comment link to dash (#692)

services/tests/test_test_results.py

@@ -106,7 +106,7 @@ def test_build_message():
         "https://example.com/build_url",
     )
     payload = TestResultsNotificationPayload(1, 2, 3, [fail], dict())
-    commit = CommitFactory()
+    commit = CommitFactory(branch="thing/thing")
     tn = TestResultsNotifier(commit, None, None, None, payload)
     res = tn.build_message()
 
@@ -136,7 +136,7 @@ def test_build_message():
 
 </details>
 
-To view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/{commit.branch})"""
+To view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/thing%2Fthing)"""
     )
 
 

services/urls.py

@@ -3,7 +3,7 @@
 from dataclasses import dataclass
 from enum import Enum
 from typing import List
-from urllib.parse import parse_qs, urlencode, urlparse, urlunparse
+from urllib.parse import parse_qs, quote_plus, urlencode, urlparse, urlunparse
 
 from shared.config import get_config
 
@@ -191,7 +191,7 @@ def get_test_analytics_url(repo: Repository, commit: Commit) -> str:
         service_short=services_short_dict.get(repo.service),
         username=repo.owner.username,
         project_name=repo.name,
-        branch_name=commit.branch,
+        branch_name=quote_plus(commit.branch),
     )