PUPPI v15 bug/crash fix for NANOAOD

[lathomas]

PR description:

This is a fix to #31927 that introduced a crash in NANOAOD workflows.
For the record, the crash only happens when running the NANO step alone, but is not visible when both NANO and DQM:@nanoAODDQM steps are run (hence why it wasn't spotted earlier).
In addition, it was noticed that some booleans were not properly set for MC when recreating the jet PUPPI collection. This is now corrected.

PR validation:

The following command ran succesfully (and is crashing before this PR):
cmsDriver.py --python_filename PPD-RunIISummer20UL17NanoAODv2-00001_1_cfg.py --eventcontent NANOAODSIM --customise Configuration/DataProcessing/Utils.addMonitoring --datatier NANOAODSIM --fileout file:nanoformat10kDY.root --conditions 112X_upgrade2018_realistic_v6 --step NANO --filein "dbs:/DYJetsToLL_M-50_TuneCP5_13TeV-amcatnloFXFX-pythia8/RunIISummer20UL18MiniAOD-Pilot_106X_upgrade2018_realistic_v11_L1v1-v2/MINIAODSIM" --era Run2_2018,run2_nanoAOD_106Xv1 --mc -n 1000

if this PR is a backport please specify the original PR and why you need to backport that PR:

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32328/20159

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167, PPS nanoAOD #31531

[cmsbuild]

A new Pull Request was created by @lathomas for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[gouskos]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_3_X_2020-11-29-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11149/console Started: 2020/11/30 08:29

[cmsbuild]

+1
Tested at: 8c91f9d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c8ea/11149/summary.html
CMSSW: CMSSW_11_3_X_2020-11-29-2300
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c8ea/11149/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529561
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[gouskos]

please test workflow 136.8522,1325.61,1325.81

[cmsbuild]

Pull request #32328 was updated. @cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mariadalfonso]

please test workflow 136.8522,1325.61,1325.81

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 1325.81,136.8522,1325.61
• CMSSW_11_3_X_2020-11-30-1100/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11162/console Started: 2020/11/30 18:16

[cmsbuild]

+1
Tested at: 649b0af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c8ea/11162/summary.html
CMSSW: CMSSW_11_3_X_2020-11-30-1100
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c8ea/11162/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-92c8ea/1325.61_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOAODMC2017_106XMiniAODv1
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-92c8ea/1325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-92c8ea/136.8522_RunJetHT2018A_nanoUL+RunJetHT2018A_nanoUL+NANOEDM2018_106Xv1+HARVESTNANOAOD2018_106Xv1

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529563
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[gouskos]

+xpog

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1