migrate Alignment/TrackerAlignment to use esConsumes

[mmusich]

PR description:

The purpose of this PR is to modernize the Alignment/TrackerAlignment subsystem, points addressed are:

• esConsumes migration: part of Migrate ED modules to use esConsumes #31061
• correct one mistake accidentally introduced in modernize Alignment/OfflineValidation: migration to esConsumes #32005

PR validation:

Branch compiles and run the unit tests successfully.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport and no backport is needed.

CAVEAT

There is a known potential merge conflict with PR #32278, once that's merged I will rebase mine.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32301/20121

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/TrackerAlignment/plugins/CosmicRateAnalyzer.cc modified in PR(s): Updated CosmicRateAnalyzer: MagField & Hits added, deleted latency #32278

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/OfflineValidation
Alignment/TrackerAlignment

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_3_X_2020-11-26-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11097/console Started: 2020/11/27 10:59

[cmsbuild]

-1

Tested at: cadcd35

CMSSW: CMSSW_11_3_X_2020-11-26-2300
SCRAM_ARCH: slc7_amd64_gcc900
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8f1d6/11097/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation warning when building: See details on the summary page.

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32301/20190

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #32301 was updated. @yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_3_X_2020-11-30-1100/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11204/console Started: 2020/12/01 11:29

[cmsbuild]

+1
Tested at: 6106859
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8f1d6/11204/summary.html
CMSSW: CMSSW_11_3_X_2020-11-30-1100
SCRAM_ARCH: slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• ParticleLevelProducer: check for leptonic decays of tag particles #32310 @intrepid42: ParticleLevelProducer: check for leptonic decays of tag particles
• Fix reflection in tower mapping in Integrity error plots #32305 @abhih1: Fix reflection in tower mapping in Integrity error plots
• adjust cp5 cr fragments to compensate P8.240 changes #32319 @agrohsje: adjust cp5 cr fragments to compensate P8.240 changes
• Adopt ChargedHadronPFTrackIsolationProducer for PFTICL candidates #32202 @hatakeyamak: Adopt ChargedHadronPFTrackIsolationProducer for PFTICL candidates
• PUPPI v15 bug/crash fix for NANOAOD #32328 @lathomas: PUPPI v15 bug/crash fix for NANOAOD
• Updated configurations in FWCore to new MessageLogger syntax #32226 @Dr15Jones: Updated configurations in FWCore to new MessageLogger syntax
• Updated CosmicRateAnalyzer: MagField & Hits added, deleted latency #32278 @saumyaphor4252: Updated CosmicRateAnalyzer: MagField & Hits added, deleted latency
• Add RecoFakeHLT steps to 2018 Patatrack WFs to enable GPU modifiers #32333 @thomreis: Add RecoFakeHLT steps to 2018 Patatrack WFs to enable GPU modifiers
• Useful items for new MessageLogger syntax #32248 @Dr15Jones: Useful items for new MessageLogger syntax

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8f1d6/11204/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8f1d6/11204/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8f1d6/11204/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529563
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[christopheralanwest]

+1

• esConsumes migration completed for this package
• no unexpected changes in PR comparison tests

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1