Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat QALOG as a text file in run-pr-comparisons #1436

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Dec 1, 2020

an occasional special character in logRootQA file can break parsing of the summary of the PR tests.
One example is in cms-sw/cmssw#32330 (comment)

Screen Shot 2020-12-01 at 2 42 39 PM

A simple test with the same file downloaded locally:

>grep SUMMARY logRootQA.log
Binary file logRootQA.log matches

>grep -a SUMMARY logRootQA.log
SUMMARY You potentially added 2947 lines to the logs
SUMMARY Reco comparison results: 0 differences found in the comparisons
SUMMARY DQMHistoTests: Total files compared: 28
...

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Dec 1, 2020

@cmsbuild please test with cms-sw/cmssw#32330

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#32330

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

-1

Tested at: 6dc3bef

CMSSW: CMSSW_11_2_X_2020-12-01-1100
SCRAM_ARCH: slc7_amd64_gcc900
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09cd6c/11243/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09cd6c/11243/summary.html

There are some workflows for which there are errors in the baseline:
4.53 step 2
136.793 step 2
136.874 step 2
4.22 step 2
136.88811 step 2
1000.0 step 2
1001.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • You potentially added 2968 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 28
  • DQMHistoTests: Total histograms compared: 2226842
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2226825
  • DQMHistoTests: Total skipped: 16
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 27 files compared)
  • Checked 128 log files, 27 edm output root files, 28 DQM output files

@smuzaffar smuzaffar merged commit 0f8285f into cms-sw:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants