-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload multiple files #34
Open
tcnichol
wants to merge
3
commits into
main
Choose a base branch
from
upload-multiple-files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,46 +26,49 @@ | |
|
||
auth_handler = AuthHandler() | ||
|
||
|
||
@router.post("/{dataset_id}", response_model=ClowderFile) | ||
async def save_file( | ||
dataset_id: str, | ||
user_id=Depends(auth_handler.auth_wrapper), | ||
db: MongoClient = Depends(dependencies.get_db), | ||
fs: Minio = Depends(dependencies.get_fs), | ||
file: UploadFile = File(...), | ||
file_info: Optional[Json[ClowderFile]] = None, | ||
@router.post("/{dataset_id}") | ||
async def save_files( | ||
dataset_id: str, | ||
user_id=Depends(auth_handler.auth_wrapper), | ||
db: MongoClient = Depends(dependencies.get_db), | ||
fs: Minio = Depends(dependencies.get_fs), | ||
files: List[UploadFile] = File(...) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could file info be just a list of original |
||
): | ||
# First, add to database and get unique ID | ||
f = dict(file_info) if file_info is not None else {} | ||
uploaded_files = [] | ||
|
||
user = await db["users"].find_one({"_id": ObjectId(user_id)}) | ||
dataset = await db["datasets"].find_one({"_id": ObjectId(dataset_id)}) | ||
f["name"] = file.filename | ||
f["creator"] = user["_id"] | ||
f["views"] = 0 | ||
f["downloads"] = 0 | ||
new_file = await db["files"].insert_one(f) | ||
found = await db["files"].find_one({"_id": new_file.inserted_id}) | ||
|
||
new_file_id = found["_id"] | ||
|
||
updated_dataset = await db["datasets"].update_one( | ||
{"_id": ObjectId(dataset_id)}, {"$push": {"files": ObjectId(new_file_id)}} | ||
) | ||
|
||
# Second, use unique ID as key for file storage | ||
while content := file.file.read( | ||
settings.MINIO_UPLOAD_CHUNK_SIZE | ||
): # async read chunk | ||
fs.put_object( | ||
settings.MINIO_BUCKET_NAME, | ||
str(new_file.inserted_id), | ||
io.BytesIO(content), | ||
length=-1, | ||
part_size=settings.MINIO_UPLOAD_CHUNK_SIZE, | ||
) # async write chunk to minio | ||
|
||
return ClowderFile.from_mongo(found) | ||
if dataset is not None and user is not None: | ||
for file in files: | ||
f = dict() | ||
f["name"] = file.filename | ||
f["creator"] = user["_id"] | ||
f["views"] = 0 | ||
f["downloads"] = 0 | ||
new_file = await db["files"].insert_one(f) | ||
found = await db["files"].find_one({"_id": new_file.inserted_id}) | ||
|
||
new_file_id = found["_id"] | ||
|
||
updated_dataset = await db["datasets"].update_one( | ||
{"_id": ObjectId(dataset_id)}, {"$push": {"files": ObjectId(new_file_id)}} | ||
) | ||
|
||
# Second, use unique ID as key for file storage | ||
while content := file.file.read( | ||
settings.MINIO_UPLOAD_CHUNK_SIZE | ||
): # async read chunk | ||
fs.put_object( | ||
settings.MINIO_BUCKET_NAME, | ||
str(new_file.inserted_id), | ||
io.BytesIO(content), | ||
length=-1, | ||
part_size=settings.MINIO_UPLOAD_CHUNK_SIZE, | ||
) # async write chunk to minio | ||
uploaded_files.append(ClowderFile.from_mongo(found)) | ||
return uploaded_files | ||
|
||
|
||
|
||
|
||
@router.get("/{file_id}") | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you left the response model out?