Upload multiple files #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith an upload multiple one
|
I decided that if there was an upload multiple files, then it makes no sense to leave a route that just uploads 1 file. This new route replaces the old one, though the parameters have changed. |
longshuicy
reviewed
Feb 4, 2022
| fs: Minio = Depends(dependencies.get_fs), | ||
| file: UploadFile = File(...), | ||
| file_info: Optional[Json[ClowderFile]] = None, | ||
| @router.post("/{dataset_id}") |
There was a problem hiding this comment.
Any reason you left the response model out?
| user_id=Depends(auth_handler.auth_wrapper), | ||
| db: MongoClient = Depends(dependencies.get_db), | ||
| fs: Minio = Depends(dependencies.get_fs), | ||
| files: List[UploadFile] = File(...) |
There was a problem hiding this comment.
could file info be just a list of original file_info instead?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This route allows for the upload of multiple files rather than just one.
For now I added it as a separate route, but there's probably no real reason to have a route for just uploading 1 file. I can remove and replace that route with this one. Please comment on the pull request if that would be better.