Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade oci-build makefile module #538

Merged

Conversation

inteon
Copy link
Member

@inteon inteon commented Jan 30, 2025

In cert-manager/makefile-modules#241 the oci_additional_layers_package_debian variable was renamed to oci_package_debian_additional_layers.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2025
@inteon inteon force-pushed the upgrade_makefile_modules branch from e05dcd8 to 02872a9 Compare January 30, 2025 09:13
@inteon inteon force-pushed the upgrade_makefile_modules branch from 02872a9 to b92dc8b Compare January 30, 2025 09:45
@inteon
Copy link
Member Author

inteon commented Jan 30, 2025

/approve
/lgtm

@cert-manager-prow
Copy link
Contributor

@inteon: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@cert-manager-prow cert-manager-prow bot merged commit dc66df0 into cert-manager:main Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant