Rename and add go build options and make them work for both oci-build and executable modules #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
inteon
force-pushed
the
go_build_options
branch
from
0dfa9c0 to
2f4509d
Compare
… and executable modules Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
go_build_options
branch
from
2f4509d to
7666840
Compare
|
/approve |
cert-manager-prow
bot
added
the
approved
SgtCoDFish
approved these changes
Jan 30, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go_$1_flagsoci_$1_linux_capabilitiescgo_enabled_$1togo_$1_cgo_enabled(to match the naming pattern used for all other go-related variables)goexperiment_$1togo_$1_goexperiment(to match the naming pattern used for all other go-related variables)oci_additional_layers_$1tooci_$1_additional_layers(to match the naming pattern used for all other oci-related variables)build_namesare no longer included in theexecutablemodule, explicitly useexe_build_namesinsteadThis PR will fix the renamed variable for the trust-manager project (only OSS project that uses these variables):
cert-manager/trust-manager#538