Stop trying to rm CRDs dir #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
SgtCoDFish
force-pushed
the
forcedelete
branch
from
f3ccadf to
92757ad
Compare
inteon
reviewed
Jan 29, 2025
This was intended to help clean up the extra CRDs dir which was created by mistake in cert-manager#239. However, a different makefile-modules PR (cert-manager#240) meant that a manual upgrade was required for downstream repos using makefile-modules anyway. As such, this is just error-prone and liable to break ci (it should've been `rm -rf` anyway). Signed-off-by: Ashley Davis <[email protected]>
SgtCoDFish
force-pushed
the
forcedelete
branch
from
92757ad to
2820b18
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to help clean up the extra CRDs dir which was created by mistake in #239.
However, a different makefile-modules PR (#240) meant that a manual upgrade was required for downstream repos using makefile-modules anyway.
As such, this is just error-prone and liable to break ci (it should've been
rm -rfanyway).