Skip to content

Commit

Permalink
remove delete of extra CRDs dir
Browse files Browse the repository at this point in the history
This was intended to help clean up the extra CRDs dir which was created
by mistake in #239.

However, a different makefile-modules PR (#240) meant that a manual
upgrade was required for downstream repos using makefile-modules anyway.

As such, this is just error-prone and liable to break ci (it should've
been `rm -rf` anyway).

Signed-off-by: Ashley Davis <[email protected]>
  • Loading branch information
SgtCoDFish committed Jan 29, 2025
1 parent 99dd04f commit 92757ad
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions modules/helm/crds.mk
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,8 @@ generate-crds: | $(NEEDS_CONTROLLER-GEN) $(NEEDS_YQ)
# TODO(@SgtCoDFish): This is a temporary fix for an accidentally created nested crds directory
# in the PR: https://github.com/cert-manager/makefile-modules/pull/239
# Once this has been run on every repo with the mistaken folder, this can be removed
rm -r $(crds_dir)/crds
rm -rf $(crds_dir)/crds

rm -rf $(crds_gen_temp)
mkdir -p $(crds_gen_temp)

$(CONTROLLER-GEN) crd \
Expand Down

0 comments on commit 92757ad

Please sign in to comment.