-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to game shortcuts and UTF8 gamelist name fixes #1126
Conversation
src/gui/components/wxGameList.cpp
Outdated
wxString appimagePath; | ||
if (wxGetEnv(("APPIMAGE"), &appimagePath)) | ||
exePath = appimagePath.utf8_string(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to introduce a reusable ActiveSettings::GetRealExecutablePath
instead of hardcoding the appimage path handling here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that ActiveSettings::GetExecutablePath
is only used for shortcuts and the autoupdater, maybe it simply should be the executable path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that makes more sense
For multi-charset systems, there may be some issues with newly created shortcut names, and the same problem occurs when copying the Title Names. Could you fix it in this PR, I tried using |
.ico
files to%LOCALAPPDATA%/Cemu/icons/