Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequentist fitting utilities and notebook #7

Merged
merged 9 commits into from
Nov 10, 2023
Merged

Conversation

dr-david
Copy link
Collaborator

@dr-david dr-david commented Nov 9, 2023

Added a jupyter notebook used to fit the model

@pawel-czyz pawel-czyz mentioned this pull request Nov 10, 2023
@pawel-czyz pawel-czyz changed the title Fitting notebook Frequentist fitting utilities and notebook Nov 10, 2023
@pawel-czyz
Copy link
Member

Overall the code looked pretty good to me! I fixed some minor issues with packaging and refactored the notebooks into Quarto, so that it's easy to run in the interactive mode in VS Code.

However, the frequentist fitting notebook didn't work on my machine:

  • There's Hessian needed, which doesn't work on my laptop.
  • The shapes are non-trivial. Sometimes we have 7 variants and sometimes 8. I tried to systematize it, but I think I only broke it, so a careful look will be required.

I think I'll merge it now and then we can think how to fix these in future PRs...

@pawel-czyz pawel-czyz merged commit 889deb2 into main Nov 10, 2023
1 check passed
@pawel-czyz pawel-czyz deleted the fitting_notebook branch November 10, 2023 22:46
@pawel-czyz pawel-czyz added the enhancement New feature or request label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants