Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eager input to *not* read input after writing it #314

Merged
merged 4 commits into from
Jan 27, 2024

test: add a quick unit test for roughly contains

c2104c9
Select commit
Loading
Failed to load commit list.
Merged

feat: eager input to *not* read input after writing it #314

test: add a quick unit test for roughly contains
c2104c9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 19, 2024 in 1s

90.29% (-0.22%) compared to e02100d

View this Pull Request on Codecov

90.29% (-0.22%) compared to e02100d

Details

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (e02100d) 90.50% compared to head (c2104c9) 90.29%.

Files Patch % Lines
scrapli/driver/base/base_driver.py 44.44% 10 Missing ⚠️
scrapli/helper.py 87.50% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   90.50%   90.29%   -0.22%     
==========================================
  Files          60       60              
  Lines        3487     3533      +46     
==========================================
+ Hits         3156     3190      +34     
- Misses        331      343      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov