Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eager input to *not* read input after writing it #314

Merged
merged 4 commits into from
Jan 27, 2024

Conversation

carlmontanari
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (e02100d) 90.50% compared to head (c2104c9) 90.29%.

Files Patch % Lines
scrapli/driver/base/base_driver.py 44.44% 10 Missing ⚠️
scrapli/helper.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   90.50%   90.29%   -0.22%     
==========================================
  Files          60       60              
  Lines        3487     3533      +46     
==========================================
+ Hits         3156     3190      +34     
- Misses        331      343      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlmontanari carlmontanari marked this pull request as ready for review January 27, 2024 01:29
@carlmontanari carlmontanari merged commit a51c862 into main Jan 27, 2024
24 of 26 checks passed
@carlmontanari carlmontanari deleted the feat/eager-input branch January 27, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant