feat: Add core watcher module #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneo8
commented
Jan 9, 2025
jneo8
commented
- Add core watcher module
- Refactor guests_on_hypervisor
jneo8
force-pushed
the
feat/add-core-watcher-module
branch
from
1aadaf1 to
2547e84
Compare
jneo8
force-pushed
the
feat/add-core-watcher-module
branch
from
9cbea7d to
aeb87ba
Compare
- Add core watcher module - Refactor guests_on_hypervisor
- fix/Read watcher configuration from clusterdb to build watcher client - doc/Update guests_on_hypervisor func docstring - doc/Add comment for TIMEOUT and TIMEOUT_INTERVAL variables
jneo8
force-pushed
the
feat/add-core-watcher-module
branch
from
aeb87ba to
2ed5ac4
Compare
| LOG.info(f"All Action plan for Audit {audit.uuid} execution successfully") | ||
|
|
||
|
|
||
| @timeout_decorator.timeout(TIMEOUT) |
There was a problem hiding this comment.
Each actionplan corresponds to multiple actions and each action can be migration. If there are more VMs to be migrated, then the actionplan may take more than TIMEOUT i.e., 3 minutes.
There was a problem hiding this comment.
The expected behavior is as follows:
- If the migration times out, the command should fail.
- When the user re-runs the command, it should fail if any VMs are still migrating, displaying a message indicating that some instances are in the migration process.
- Once all migration watcher actions are complete, re-running the command should result in success.
…her action - Refactor: Replace timeout decorator by tenacity - Fix: Raise exception on failed watcher action
hemanthnakkina
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Minor comments inline.
Couple of things to improve upon as separate PRs:
- Show progress of maintenance actions in cli (similar to how deployment control plane shows during bootstrap command)
- Return meaningful output at end of maintenance
For example,
If maintenance is failed or timed out, list of actions that are completed, actions that are in error state with reason and actions that are still pending.
| @@ -98,3 +98,7 @@ min-file-size = 1 | |||
|
|
|||
| [tool.ruff.lint.mccabe] | |||
| max-complexity = 15 | |||
|
|
|||
| [[tool.mypy.overrides]] | |||
| module = ["watcherclient.*", "timeout_decorator"] | |||
There was a problem hiding this comment.
timeout_decorator is not need here
|
|
||
| @tenacity.retry( | ||
| reraise=True, | ||
| stop=tenacity.stop_after_delay(WAIT_TIMEOUT), |
There was a problem hiding this comment.
As discussed, the WAIT_TIMEOUT should adjust based on number of actions it has to perform. Otherwise user might end up to run sunbeam maintenance command multiple times if there are more instances to migrate.
| client: watcher_client.Client, audit: watcher.Audit | ||
| ) -> list[watcher.Action]: | ||
| """Get list of actions by audit.""" | ||
| return client.action.list(audit=audit.uuid, detail=True) |
There was a problem hiding this comment.
Add limit=0 to get all the actions [1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.