Feat/add maintenance steps #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneo8
force-pushed
the
feat/add-maintenance-steps
branch
from
5d44997 to
dd789b3
Compare
- Add core watcher module - Refactor guests_on_hypervisor
- fix/Read watcher configuration from clusterdb to build watcher client - doc/Update guests_on_hypervisor func docstring - doc/Add comment for TIMEOUT and TIMEOUT_INTERVAL variables
…her action - Refactor: Replace timeout decorator by tenacity - Fix: Raise exception on failed watcher action
- Add EnableHypervisorStep, RunWatcherHostMaintenanceStep, and RunWatcherWorkloadBalancingStep
jneo8
force-pushed
the
feat/add-maintenance-steps
branch
from
dd789b3 to
13e055a
Compare
hemanthnakkina
requested changes
Jan 17, 2025
| run_sync(self.jhelper.run_action(self.unit, self.model, "enable")) | ||
| except ActionFailedException as e: | ||
| LOG.debug(str(e)) | ||
| return Result(ResultType.FAILED, "Failed to enable hypervisor unit") |
There was a problem hiding this comment.
Add unit name in error message. Helps user not to bother about mapping unit name to node name.
| f" | parameters: {action.input_parameters}\n" | ||
| ) | ||
| question = ConfirmQuestion( | ||
| ("Confirm to run operations for cluster:\n" f"{action_operation_msg}"), |
There was a problem hiding this comment.
Can you update in Github Conversation first commit message box with the UX along with output.
Is the user will be prompted to accept the actions for every Step that contains has_prompts as True? In other words, user accepts the actions for Hypervisor maintenance using watcher once and then after some time for Storage related?
Do you have plan to add maintenance commands that list all actions required across hypervisor/k8s/microceph?
Do you have plan to add flag to proceed with maintenance without prompts once user has reviewed the actionplan in total?
|
Move to #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by: #397