Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to charmcraft 3 #116

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Update to charmcraft 3 #116

merged 2 commits into from
Oct 26, 2024
+9 −3

Conversation

samuelallan72
Copy link
Contributor

Fixes: #95

@samuelallan72 samuelallan72 requested a review from a team as a code owner October 24, 2024 05:26
@samuelallan72 samuelallan72 mentioned this pull request Oct 24, 2024
Merged
chanchiwai-ray
chanchiwai-ray approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@chanchiwai-ray chanchiwai-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, side question: do we need to update charmcraft.yaml?

@samuelallan72
Copy link
Contributor Author

do we need to update charmcraft.yaml?

I believe not - it builds fine. :)

@gabrielcocenza
Copy link
Member

LGTM, side question: do we need to update charmcraft.yaml?

I thought the same....

I imagine that it's not every project that will work

@samuelallan72
Copy link
Contributor Author

I imagine that it's not every project that will work

Yes, some projects will not work, but most should be fine. We originally pinned everything to charmcraft 2 even if it seemed to work, because of some bugs in earlier releases of charmcraft 3 around handling of bases.

@samuelallan72 samuelallan72 merged commit b9fb8f8 into main Oct 26, 2024
3 checks passed
@samuelallan72 samuelallan72 deleted the charmcraft3 branch October 26, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@aieri aieri aieri approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support charmcraft 3
4 participants
@samuelallan72 @gabrielcocenza @aieri @chanchiwai-ray