Skip to content

Commit

Permalink
Update to charmcraft 3 (#116)
Browse files Browse the repository at this point in the history
Fixes: #95
  • Loading branch information
samuelallan72 authored Oct 26, 2024
1 parent 038d81f commit b9fb8f8
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:

- name: install external controller required packages
run: |
sudo snap install charmcraft --channel 2.x/stable --classic
sudo snap install charmcraft --channel 3.x/stable --classic
sudo snap install juju --channel 3.4/stable --classic
sudo --preserve-env=http_proxy,https_proxy,no_proxy pip3 install tox
juju switch soleng-ci-ctrl-34
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/promote.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
destination-channel: ${{ steps.set-channels.outputs.destination-channel }}
origin-channel: ${{ steps.set-channels.outputs.origin-channel }}
charmcraft-channel: "2.x/stable"
charmcraft-channel: "3.x/stable"
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Pack and upload to charmhub
uses: canonical/charming-actions/[email protected]
with:
charmcraft-channel: "2.x/stable"
charmcraft-channel: "3.x/stable"
credentials: "${{ secrets.CHARMHUB_TOKEN }}"
github-token: "${{ secrets.GITHUB_TOKEN }}"
# Ensure the charm is built in an isolated environment and on the correct base in an lxd container.
Expand Down
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ This script is also executed periodically as part of a GitHub Actions workflow t

## Build the charm

Charmcraft v3 is required to build this charm:

```
sudo snap install charmcraft --channel 3.x/stable --classic
```

Build the charm in this git repository using:

```shell
Expand Down

0 comments on commit b9fb8f8

Please sign in to comment.