fix: Disable custom templates for trialing teams #18748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeauyeung
commented
Jan 19, 2025
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
bot
added
billing
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/19/25)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
Udit-takkar
reviewed
Jan 20, 2025
| id: input.teamId, | ||
| members: { | ||
| some: { | ||
| userId: userId, |
There was a problem hiding this comment.
we should also add accepted: true
|
My main concern with this approach is that we're introducing a Stripe overhead in the check. I'd recommend an alternative approach where we check the |
iharsh02
pushed a commit
to iharsh02/cal.com
that referenced
this pull request
Jan 20, 2025
* Create `checkIfTeamHasActivePlan` method on `stripe-billing-service` * Add `checkIfTeamPlanIsActive` to `InternalTeamBilling` * Create `hasActiveTeamPlan` trpc endpoint * Check for active team plan when updating workflows * Create `useHasActiveTeamPlan` hook * Use `useHasActiveTeamPlan` on workflow edit page * Type fixes * Type fix * Add `accepted` to team query
CarinaWolli
reviewed
Jan 20, 2025
| const { step, form, reload, setReload, teamId } = props; | ||
| const { data: _verifiedNumbers } = trpc.viewer.workflows.getVerifiedNumbers.useQuery( | ||
| { teamId }, | ||
| { enabled: !!teamId } | ||
| ); | ||
|
|
||
| const { hasActiveTeamPlan } = useHasActiveTeamPlan(teamId); |
There was a problem hiding this comment.
@joeauyeung Now we only allow custom templates on team workflows but not on User workflows for user's that are part of a team or org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Builds off of #18635
https://www.loom.com/share/3701b3a6ab5f4632b2420072f00b0c7d
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist