You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Merging into staging now that brave/brave-core#22768 was uplifted/merged into 1.65.x. Once we get a new RC with brave/brave-core#22768, we'll run through the above study on main (staging).
Quick Note: Currently there's no feature(s) that are using DayZeroStudyWindows so with the following verifications, ensured that you're placed into the different cohorts that are available. The P3A portion was verified via brave/brave-browser#36243.
Win 11 x64 verification(s):
Verification PASSED on Win 11 x64 using the following build(s):
Brave | 1.65.114 Chromium: 124.0.6367.60 (Official Build) (64-bit)
-- | --
Revision | f1e2cbb65e11340d9040d5ef0b0115c7a5206207
OS | Windows 11 Version 23H2 (Build 22631.3447)
Release channel - DayZeroStudyWindows:Default
launched/re-launched 1.65.114 Chromium: 124.0.6367.60 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
Release channel - DayZeroStudyWindows:EnabledA
launched/re-launched 1.65.114 Chromium: 124.0.6367.60 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
Release channel - DayZeroStudyWindows:EnabledB
launched/re-launched 1.65.114 Chromium: 124.0.6367.60 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
BETA channel - DayZeroStudyWindows should be used/visible (only on Release)
Verification PASSED on Win 11 x64 using the following build(s):
Brave | 1.66.80 Chromium: 124.0.6367.29 (Official Build) beta (64-bit)
-- | --
Revision | 2d822a1940c9159c1f307cd1c0a8f58fcfb50fe0
OS | Windows 11 Version 23H2 (Build 22631.3447)
launched/re-launched 1.66.80 Chromium: 124.0.6367.29 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
ensured that DayZeroStudyWindows doesn't appear within brave://version
Nightly channel - DayZeroStudyWindows should be used/visible (only on Release)
Verification PASSED on Win 11 x64 using the following build(s):
Brave | 1.67.15 Chromium: 124.0.6367.29 (Official Build) nightly (64-bit)
-- | --
Revision | eb30d51fbd9c8d0f2960f50f9df8d07a44a87694
OS | Windows 11 Version 23H2 (Build 22631.3447)
launched/re-launched 1.67.15 Chromium: 124.0.6367.29 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
ensured that DayZeroStudyWindows doesn't appear within brave://version
Quick Note: Currently there's no feature(s) that are using DayZeroStudyAndroid so with the following verifications, ensured that you're placed into the different cohorts that are available. The P3A portion was verified via brave/brave-browser#36243.
Android verification(s):
Verification PASSED on Pixel 6 running Android 14 using the following build(s):
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.