Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore full checkdeps run in brave directory. #27175

Merged
merged 1 commit into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions build/commands/lib/gnCheck.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ const gnCheck = (buildConfig = config.defaultBuildConfig, options = {}) => {
config.buildConfig = buildConfig
config.update(options)
util.run('gn', ['check', config.outputDir], config.defaultOptions)
util.run(
'python3',
[
'buildtools/checkdeps/checkdeps.py',
'brave',
'--extra-repos=brave',
'--no-resolve-dotdot'
],
config.defaultOptions
)
}

module.exports = gnCheck
2 changes: 2 additions & 0 deletions chromium_src/chrome/renderer/DEPS
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
include_rules = [
"+brave/components/ai_chat/core/common",
"+brave/components/ai_chat/renderer",
"+brave/components/body_sniffer",
"+brave/components/brave_shields/core/common",
"+brave/components/content_settings/renderer",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include "net/base/features.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
#include "net/cookies/site_for_cookies.h"
#include "third_party/abseil-cpp/absl/base/attributes.h"
#include "url/gurl.h"
#include "url/origin.h"

Expand Down
79 changes: 79 additions & 0 deletions components/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,82 @@ include_rules = [
# these dependencies; see /components/README.
"-ipc",
]

specific_include_rules = {
# IMPORTANT: Do not add new browser tests that depend on //chrome or
# //brave/browser/ to //brave/components.
#
# This is an exclusion list for browser tests written before proper dependency
# checking was implemented. These tests should be migrated out of
# //brave/components into //brave/browser eventually.
"android_page_appearing_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"brave_content_settings_agent_impl_browsertest\.cc": [
"+chrome",
"+content",
],
"brave_wayback_machine_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"de_amp_browsertest\.cc": [
"+chrome",
"+content",
],
"perf_predictor_tab_helper_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"rewards_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"rewards_browsertest_context_helper\.cc": [
"+brave/browser",
"+chrome",
],
"rewards_browsertest_context_helper\.h": [
"+chrome",
],
"rewards_browsertest_contribution\.cc": [
"+chrome",
],
"rewards_browsertest_response\.cc": [
"+chrome",
],
"rewards_browsertest_util\.cc": [
"+brave/browser",
"+chrome",
],
"rewards_contribution_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"rewards_flag_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"rewards_notification_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"rewards_p3a_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"rewards_publisher_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"rewards_state_browsertest\.cc": [
"+brave/browser",
"+chrome",
],
"webcompat_exceptions_browsertest\.cc": [
"+brave/browser",
"+chrome",
"+content",
],
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "brave/components/brave_search/common/brave_search_utils.h"
#include "brave/components/brave_search/renderer/brave_search_fallback_js_handler.h"
#include "content/public/renderer/worker_thread.h"
#include "third_party/abseil-cpp/absl/base/attributes.h"
#include "url/gurl.h"

namespace brave_search {
Expand All @@ -25,7 +24,7 @@ namespace {
class JsHandlersForCurrentThread;

// A thread local pointer for the js handlers available.
ABSL_CONST_INIT thread_local JsHandlersForCurrentThread* current_js_handlers =
constinit thread_local JsHandlersForCurrentThread* current_js_handlers =
nullptr;

// A scoping class to create a local thread storage for the JS handlers, storing
Expand Down
Loading