Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore full checkdeps run in brave directory. #27175

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Jan 9, 2025

Presubmits do not cover all checkdeps files, so we should still run it on all files.

Resolves brave/brave-browser#43202

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov marked this pull request as ready for review January 9, 2025 12:53
@goodov goodov requested review from a team as code owners January 9, 2025 12:53
@goodov goodov merged commit 0d47da4 into master Jan 9, 2025
21 checks passed
@goodov goodov deleted the restore-full-checkdeps branch January 9, 2025 13:59
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 9, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore full brave/ checkdeps run to catch rare issues on file deletion/moving
3 participants