Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Open the connect panel when the same origin requests to connect more than once" #27119

Conversation

vadimstruts
Copy link
Collaborator

@vadimstruts vadimstruts commented Jan 5, 2025

Reverts #18650
Resolves brave/brave-browser#43147

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Signed-off-by: Vadym Struts <[email protected]>
@vadimstruts vadimstruts merged commit dd9c87a into master Jan 5, 2025
19 checks passed
@vadimstruts vadimstruts deleted the revert-27729-open-the-connect-panel-when-the-same-origin-requests-to-connect-more-than-once branch January 5, 2025 11:14
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Jan 5, 2025
@brave-builds
Copy link
Collaborator

Released in v1.75.147

@kjozwiak
Copy link
Member

kjozwiak commented Jan 8, 2025

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.75.151 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
-- | --
Revision | f122bf6d4cf815cc56e1ba5cf1dda5e9fc20b689
OS | Windows 11 Version 24H2 (Build 26100.2605)

Verification notes can be found via https://github.com/brave/internal/issues/1241#issuecomment-2576638851.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hackerone] Crash+DOS Using Race Condition in Wallet Connect
4 participants