Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Open the connect panel when the same origin requests to connect more than once" (uplift to 1.73.x) #27121

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Revert "Open the connect panel when the same origin requests to connect more than once" (uplift to 1.73.x) #27121

merged 1 commit into from
Jan 8, 2025

Conversation

vadimstruts
Copy link
Collaborator

@vadimstruts vadimstruts commented Jan 5, 2025 •
edited by kjozwiak
Loading

Uplift of #27119
Reverts #18650
Resolves brave/brave-browser#43147

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@vadimstruts
reverted PR #18650
38a89da 
Signed-off-by: Vadym Struts <[email protected]>
@vadimstruts vadimstruts marked this pull request as ready for review January 5, 2025 11:51
@vadimstruts vadimstruts requested a review from a team as a code owner January 5, 2025 11:51
@kjozwiak kjozwiak added this to the 1.73.x - Release #7 milestone Jan 7, 2025
kjozwiak
kjozwiak approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.73.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #27119 (comment).

@kjozwiak kjozwiak merged commit e632ba0 into 1.73.x Jan 8, 2025
17 checks passed
@kjozwiak kjozwiak deleted the pr27119_revert-27729-open-the-connect-panel-when-the-same-origin-requests-to-connect-more-than-once_1.73.x branch January 8, 2025 03:28
@brave-builds
Copy link
Collaborator

Released in v1.73.105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@vadimstruts vadimstruts

Labels
feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.73.x - Release #7
Development

Successfully merging this pull request may close these issues.
3 participants
@vadimstruts @brave-builds @kjozwiak