Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "day zero" experiment feature & metrics (uplift to 1.65.x) #22768

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add "day zero" experiment feature & metrics (uplift to 1.65.x) #22768

merged 1 commit into from
Apr 11, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 26, 2024 •
edited by kjozwiak
Loading

Uplift of #22195
Uplift of #22892
Resolves brave/brave-browser#36243

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner March 26, 2024 04:12
@brave-builds brave-builds added this to the 1.65.x - Beta milestone Mar 26, 2024
@brave-builds brave-builds self-assigned this Mar 26, 2024
@github-actions github-actions bot added the CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) label Mar 26, 2024
@DJAndries DJAndries force-pushed the pr22195_day-zero-p3a_1.65.x branch from 0d10372 to 311b269 Compare April 3, 2024 19:22
@kjozwiak kjozwiak mentioned this pull request Apr 11, 2024
Closed
24 tasks
kjozwiak
kjozwiak approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.65.x approved 👍 QA has verified the PR on Nightly via 1.67.x as per #22195 (comment).

@kjozwiak kjozwiak merged commit 81afde3 into 1.65.x Apr 11, 2024
14 checks passed
@kjozwiak kjozwiak deleted the pr22195_day-zero-p3a_1.65.x branch April 11, 2024 05:26
@kjozwiak kjozwiak mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.65.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak