Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] Use sr-only text #692

Merged
merged 3 commits into from
Dec 16, 2024
Merged

[Frontend] Use sr-only text #692

merged 3 commits into from
Dec 16, 2024

Conversation

ozdentarikcan
Copy link
Contributor

📋 Proposed Changes

  • Use sr-only text instead of aria labels for non-interactive elements.
  • Make loading messages visible.

Related Issue

Closes #609

🧪 Included Tests

  • Loading messages are seen in Profile and Search pages.

@ozdentarikcan ozdentarikcan added type: enhancement New feature or request priority: medium Medium priority component: frontend About frontend labels Dec 16, 2024
@ozdentarikcan ozdentarikcan requested a review from mmtftr December 16, 2024 11:35
@ozdentarikcan ozdentarikcan self-assigned this Dec 16, 2024
mmtftr
mmtftr requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mmtftr mmtftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the work. short changes are requested

frontend/src/components/FullscreenLoading.tsx Show resolved Hide resolved
mmtftr
mmtftr requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mmtftr mmtftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested

frontend/src/components/FullscreenLoading.tsx Show resolved Hide resolved
@ozdentarikcan ozdentarikcan requested a review from mmtftr December 16, 2024 15:38
mmtftr
mmtftr approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mmtftr mmtftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@ozdentarikcan ozdentarikcan merged commit db045ce into develop Dec 16, 2024
1 check passed
@ozdentarikcan ozdentarikcan mentioned this pull request Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmtftr mmtftr mmtftr approved these changes

Assignees

@ozdentarikcan ozdentarikcan

Labels
component: frontend About frontend priority: medium Medium priority type: enhancement New feature or request
Projects
None yet
Milestone
451 - Customer Milestone 3 - Final Pr...
Development

Successfully merging this pull request may close these issues.
2 participants
@ozdentarikcan @mmtftr