Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Accessibility: Use sr-only text instead of aria-label on non-interactive elements #609

Closed
mmtftr opened this issue Dec 6, 2024 · 1 comment
Assignees
Labels
component: frontend About frontend priority: medium Medium priority

Comments

@mmtftr
Copy link
Contributor

mmtftr commented Dec 6, 2024

Description

Due to feedback we received in our milestone presentation, we realized we should use sr-only text instead of aria-label for non-interactive elements such as icons that denote information.

For example, any non-button non-anchor element that has aria-label text should have its text placed like so:

// previously
return <div aria-label="Lorem ipsum dolor">
  <Icon/>
   Some info
</div>

// now
return <div>
   <Icon/>
   <span className="sr-only">Text describing icon</span>
   Some info
</div>
@ozdentarikcan
Copy link
Contributor

Closed with PR #692.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: frontend About frontend priority: medium Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants